Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated separating set testing as a subprocedure #119

Open
adam2392 opened this issue Feb 16, 2023 · 1 comment
Open

Repeated separating set testing as a subprocedure #119

adam2392 opened this issue Feb 16, 2023 · 1 comment
Labels
constraint-algorithm Constraint based discovery algorithms enhancement New feature or request help wanted Extra attention is needed

Comments

@adam2392
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Faithfulness is commonly violated. One aspect of the problem is the (incorrect) orientation of colliders, which then lead to (incorrect) orientation of downstream edges.

Describe the solution you'd like
https://proceedings.neurips.cc/paper/2019/file/e6872f5bbe75073f8c7cfb93de7f6f3a-Paper.pdf introduces a simple procedure for iteratively running PC/FCI algorithms.

We should implement a similar abstraction, but make it optional for users since it essentially results in a drastic increase in computation.
@adam2392 adam2392 added enhancement New feature or request help wanted Extra attention is needed constraint-algorithm Constraint based discovery algorithms labels Feb 20, 2023
@adam2392
Copy link
Collaborator Author

Supposedly this has a bug in the procedure, as raised by Adele Ribeiro via some counter-examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
constraint-algorithm Constraint based discovery algorithms enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@adam2392