Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate dependencies are sometimes added to requirements file with --fix #578

Closed
tetsuo-cpp opened this issue Mar 24, 2023 · 0 comments · Fixed by #577
Closed

Duplicate dependencies are sometimes added to requirements file with --fix #578

tetsuo-cpp opened this issue Mar 24, 2023 · 0 comments · Fixed by #577
Labels
bug Something isn't working component:dep-sources Dependency sources component:fixes Automatic fixing

Comments

@tetsuo-cpp
Copy link
Contributor

tetsuo-cpp commented Mar 24, 2023 •
edited
Loading

As described by @q0w at #564 (comment), duplicate dependencies are sometimes added to requirements files when running --fix.

Since we're getting package names from pip, we need to use the canonical name when checking whether the the dependency exists as a requirement already.

This is a 2.5.0 regression.
@tetsuo-cpp tetsuo-cpp added bug-candidate Might be a bug. bug Something isn't working component:dep-sources Dependency sources component:fixes Automatic fixing and removed bug-candidate Might be a bug. labels Mar 24, 2023
@tetsuo-cpp tetsuo-cpp mentioned this issue Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:dep-sources Dependency sources component:fixes Automatic fixing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

requirement: Check requirements using the canonical name when fixing pypa/pip-audit
1 participant
@tetsuo-cpp