Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a warning in twine check when Requires-Python is unset #854

Open
webknjaz opened this issue Jan 6, 2022 · 2 comments
Open

Emit a warning in twine check when Requires-Python is unset #854

webknjaz opened this issue Jan 6, 2022 · 2 comments
Labels
blocked Issues we can't or shouldn't get to yet feature request

Comments

@webknjaz
Copy link
Member

webknjaz commented Jan 6, 2022

Your Environment

N/A

The Issue

While filing an issue about a missing python_requires in yet another project (joeyespo/pytest-watch#125) I suddenly realized that I've filed a few related feature requests in Twine already but when I've checked them, I saw that I never asked to validate its presence (I only asked to compare it with the wheel tags @ #739). So I thought I'd record another possibly useful check to be added.

Steps to Reproduce

N/A

@bhrutledge bhrutledge added the blocked Issues we can't or shouldn't get to yet label Jan 10, 2022
@bhrutledge
Copy link
Contributor

@webknjaz Thanks for the suggestion. Once again, I think this is similar to #430, which is blocked on pypa/packaging#147. However, I have an initial proposal for an alternative approach in #848; I'd appreciate your feedback.

@webknjaz
Copy link
Member Author

It is somewhat similar to the blocked issue but the difference is that this kind of check is not something that the packaging ecosystem is enforcing currently — people can upload dists without Requires-Python, it's not illegal. And the proposed improvement would need to be added on the twine side, not to packaging or wherever the shared code would end up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Issues we can't or shouldn't get to yet feature request
Projects
None yet
Development

No branches or pull requests

2 participants