Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing tox.ini #164

Open
mtelka opened this issue Jul 19, 2023 · 3 comments
Open

sdist is missing tox.ini #164

mtelka opened this issue Jul 19, 2023 · 3 comments

Comments

@mtelka
Copy link

mtelka commented Jul 19, 2023

The sdist package at PyPI is missing tox.ini. Please add the missing tox.ini file to sdist to make downstream testing easier. Thank you.

@zanieb
Copy link
Contributor

zanieb commented Jul 19, 2023

Hey @mtelka — I don't think it's common to include testing utilities in sdists. Can you point to other packages that do this? Why aren't you cloning from git if you're doing development on this project?

@mtelka
Copy link
Author

mtelka commented Jul 19, 2023

I'm packaging h11 (and hundreds of other Python projects) for OpenIndiana and tests included in sdist are common. Yes, there are some people that do not want tests in sdist but they are minority only.

An recent example: pypa/distlib#206

I have plenty of similar cases when some files needed for tests were missing and after a bug report such files were added.
There is also (much longer) list of projects that include full tests properly since day zero.

Thank you.

@zanieb
Copy link
Contributor

zanieb commented Jul 19, 2023

Makes sense. The tests are already in the main module here so it seems reasonable. Perhaps you want to open a pull request? It's trivial to add e.g. pypa/distlib@ff48e09

I'm not a maintainer here though — just a contributor.

Related #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants