Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 107&108 optional? #117

Closed
jakkdl opened this issue Jan 30, 2023 · 1 comment · Fixed by #123
Closed

Make 107&108 optional? #117

jakkdl opened this issue Jan 30, 2023 · 1 comment · Fixed by #123
Assignees

Comments

@jakkdl
Copy link
Member

jakkdl commented Jan 30, 2023

Now that we have added optional checks, I was struck by the thought that maybe 107&108 should be made optional as well? I remember it being singled out when you'd previously discussed it with other Trio folks, and as far as I understand they're not really errors - and it's highly viable to write a codebase where you only take as assumption that calls to the trio library guarantees checkpoints - but not when calling your own async functions.
When transitioning a codebase to use this plugin I also imagine that they're going to be among the noisiest checks, and you might only want to enable them after fixing all the other checks.

@Zac-HD
Copy link
Member

Zac-HD commented Feb 1, 2023

Yeah, makes sense, let's do it.

My intuition says "No, missing checkpoints break cancellation" - but so do async generators, and we made that check optional too for good reason. Noisy alarms just get ignored, so let's take the pragmatic path and disable by default. (#70 will also improve this a bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants