You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As a followup to #2584 and #2585 and as I've already been thinking about lately and discussed with @JelleZijlstra and @warsaw at PyCon, right now we parse the headers three different places with three different sets of logic:
pep_zero_generator.parser for PEP 0, the JSON and the RSS with some additional sub-parsing in those callers
pep_processor.transforms.header_transform for the PEP rendering
The .pre-commit-config.yaml pygrep hooks for linting),
Instead, we should just use the structured format I suggest in #2584 (with the parsing presumably in the PEP class) for all of them (starting with PEP rendering initially), for several reasons:
Simpler, more DRY, reliable and maintainable in the long run
Of course, we should decide on and implement the structured format proposed in #2584 first, as it is a perquisite for this (alongside the changes in #2585 and #2579 needing to be merged before work on this begins), but I've opened this to keep track of it.
The text was updated successfully, but these errors were encountered:
As a followup to #2584 and #2585 and as I've already been thinking about lately and discussed with @JelleZijlstra and @warsaw at PyCon, right now we parse the headers three different places with three different sets of logic:
pep_zero_generator.parser
for PEP 0, the JSON and the RSS with some additional sub-parsing in those callerspep_processor.transforms.header_transform
for the PEP renderingThe .pre-commit-config.yaml
pygrep hooks for linting),Instead, we should just use the structured format I suggest in #2584 (with the parsing presumably in the
PEP
class) for all of them (starting with PEP rendering initially), for several reasons::abbr:
from Waste less vertical space at top of rendered PEP #2514 )Of course, we should decide on and implement the structured format proposed in #2584 first, as it is a perquisite for this (alongside the changes in #2585 and #2579 needing to be merged before work on this begins), but I've opened this to keep track of it.
The text was updated successfully, but these errors were encountered: