Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to "merge" sponsor objects in python.org/admin #2370

Open
loren-c opened this issue Feb 16, 2024 · 2 comments
Open

A way to "merge" sponsor objects in python.org/admin #2370

loren-c opened this issue Feb 16, 2024 · 2 comments
Labels
app/sponsors Relates to the sponsors app backend Relates to the backend of the app
Milestone

Comments

@loren-c
Copy link
Contributor

loren-c commented Feb 16, 2024

Is your feature request related to a problem? Please describe.
Sometimes when submitting an application on our sponsor application page , sponsors will unintentionally create a second sponsor object for the same company.

This creates problems with populating renewal dates among other things--If the contract is a renewal, but it is not connected to the sponsor object associated with the last contract, the date of last contract is "UNKNOWN" and when I try to download the renewal contract I get a 500 error.

Describe the solution you'd like
It would be nice to have a way in https://www.python.org/admin/sponsors/sponsor/ to merge duplicate sponsor objects. Ideally they would retain the information/files from the most recently created sponsor object and/or ask which to retain.

Describe alternatives you've considered
Currently I haven't been able to find a way to generate a renewal contract in the case of duplicate sponsor objects, so I've just been manually creating the contract from the template in those cases. (E.g. frequently the sponsor contacts change from year to year, and sometimes the logo gets updated or other details change.)

Additional context

Screenshot 2024-02-16 at 17-11-13 Select sponsor to change python org

@ewdurbin

@JacobCoffee JacobCoffee added the backend Relates to the backend of the app label Sep 16, 2024
@JacobCoffee JacobCoffee added the app/sponsors Relates to the sponsors app label Sep 16, 2024
@JacobCoffee JacobCoffee added this to the 1H25 milestone Sep 16, 2024
@JacobCoffee
Copy link
Member

As a side note, maybe we should restrict the sponsor field name to be unique to prevent the users from doing this

@loren-c
Copy link
Contributor Author

loren-c commented Sep 27, 2024

The only potential issue with that is sometimes the person submitting the application isn't already associated with the sponsor, so it could result in those people not submitting an application if they are blocked from using the company name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app/sponsors Relates to the sponsors app backend Relates to the backend of the app
Projects
Status: Backlog
Development

No branches or pull requests

2 participants