Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: View provided assets button takes you to the full assets list #2577

Closed
JacobCoffee opened this issue Sep 17, 2024 · 0 comments · Fixed by #2593
Closed

Bug: View provided assets button takes you to the full assets list #2577

JacobCoffee opened this issue Sep 17, 2024 · 0 comments · Fixed by #2593
Assignees
@JacobCoffee
Labels
app/sponsors Relates to the sponsors app bug This is a bug! frontend Relates to the frontend of the app
Milestone
2H24

Comments

@JacobCoffee
Copy link
Member

What

When a sponsor is viewing their profile, users/sponsorships/$ID,they can click into a specific asset:

image

However, clicking this link browses to users/sponsorships/$ID/provided-assets/?provided_asset=## where the query passed, ?provided_asset=## does nothing.

Expected Behavior

When you click “view asset” , go to only the single specific asset and not the list of all assets

Extra

  • Get rid of “Or you can also click here to view all the assets under the same page?
@JacobCoffee JacobCoffee added bug This is a bug! frontend Relates to the frontend of the app app/sponsors Relates to the sponsors app labels Sep 17, 2024
@JacobCoffee JacobCoffee added this to the 2H24 milestone Sep 17, 2024
@JacobCoffee JacobCoffee moved this to In Progress in Staff and Board Requests Sep 19, 2024
@JacobCoffee JacobCoffee self-assigned this Sep 19, 2024
@JacobCoffee JacobCoffee closed this as completed by moving to In Progress in Staff and Board Requests Sep 19, 2024
JacobCoffee added a commit that referenced this issue Sep 19, 2024
@JacobCoffee
fix: links are direct to assett
b3e7045 
Closes: #2577
@JacobCoffee JacobCoffee mentioned this issue Sep 19, 2024
Merged
@JacobCoffee JacobCoffee reopened this Sep 19, 2024
JacobCoffee added a commit that referenced this issue Sep 20, 2024
@JacobCoffee
Merge branch 'main' into #2577-asset-view
a30673a
JacobCoffee added a commit that referenced this issue Sep 20, 2024
@JacobCoffee
Merge branch 'main' into #2577-asset-view
00c3394
JacobCoffee added a commit that referenced this issue Sep 23, 2024
@JacobCoffee
Merge branch 'main' into #2577-asset-view
3f38e85
JacobCoffee added a commit that referenced this issue Sep 26, 2024
@JacobCoffee
Merge branch 'main' into #2577-asset-view
905c9e6
JacobCoffee added a commit that referenced this issue Sep 26, 2024
@JacobCoffee
Merge branch 'main' into #2577-asset-view
aaf5105
JacobCoffee added a commit that referenced this issue Oct 8, 2024
@JacobCoffee
fix: links are direct to assett
356af6a 
Closes: #2577
@github-project-automation github-project-automation bot moved this from In Progress to Complete in Staff and Board Requests Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JacobCoffee JacobCoffee

Labels
app/sponsors Relates to the sponsors app bug This is a bug! frontend Relates to the frontend of the app
Projects
Staff and Board Requests
Status: Complete
Milestone
2H24
Development

Successfully merging a pull request may close this issue.

fix: links are direct to asset python/pythondotorg
1 participant
@JacobCoffee