Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug(sponsors): When creating a new sponsor app the first contact should default to the primary #2610

Open
JacobCoffee opened this issue Sep 26, 2024 · 0 comments · May be fixed by #2648
Open

Bug(sponsors): When creating a new sponsor app the first contact should default to the primary #2610

JacobCoffee opened this issue Sep 26, 2024 · 0 comments · May be fixed by #2648
Labels
app/sponsors Relates to the sponsors app bug This is a bug! frontend Relates to the frontend of the app good-first-issue This is good for newcomers to take on help-wanted The maintainers would welcome help with this issue sponsor-applications Relates to sponsor applications at python.org/sponsors/application/

Comments

@JacobCoffee
Copy link
Member

JacobCoffee commented Sep 26, 2024 •
edited
Loading

Describe the bug

New sponsors form fails due to missed checkbox

image

To Reproduce

  1. Create sponsorship application
  2. Once you enter into, submit
  3. Be met with angry form invalidation:
    image

Expected behavior

The first contact is usually going to be the primary. By defaulting this to checked we save some annoyance and headache for users having to reupload images because they forgot to click the box.

URL to the issue

pythondotorg/sponsors/models/sponsors.py

Line 154 in 096ac33

primary = models.BooleanField(

Screenshots

No response

Browsers

Other

Operating System

Other

Browser Version

No response

Relevant log output

No response

Additional context

No response
@JacobCoffee JacobCoffee added bug This is a bug! frontend Relates to the frontend of the app help-wanted The maintainers would welcome help with this issue good-first-issue This is good for newcomers to take on sponsor-applications Relates to sponsor applications at python.org/sponsors/application/ app/sponsors Relates to the sponsors app labels Sep 26, 2024
dorian-adams added a commit to dorian-adams/pythondotorg that referenced this issue Oct 26, 2024
@dorian-adams
Bug (sponsors): Default primary contact field to True for first contact
9a2622e 
Set the initial `primary` contact value to True in the form, ensuring only the first contact is marked as primary. All additional contact forms added will default to False.
Form validation remains unchanged in the event that the `primary` field is unchecked by the user.

Closes python#2610
@dorian-adams dorian-adams linked a pull request Oct 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app/sponsors Relates to the sponsors app bug This is a bug! frontend Relates to the frontend of the app good-first-issue This is good for newcomers to take on help-wanted The maintainers would welcome help with this issue sponsor-applications Relates to sponsor applications at python.org/sponsors/application/
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug (sponsors): Default primary contact field to True for first contact dorian-adams/pythondotorg
1 participant
@JacobCoffee