Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide initial phase to Griffin-Lim #3828

Open
aaron-dees opened this issue Aug 27, 2024 · 0 comments
Open

Ability to provide initial phase to Griffin-Lim #3828

aaron-dees opened this issue Aug 27, 2024 · 0 comments

Comments

@aaron-dees
Copy link

🚀 The feature

Ability to provide initial phase to griffin-lim, for phase reconstruction.

Motivation, pitch

pytorchaudio has a Griffin-Lim implementation to reconstruct audio from spectrogram magnitudes. Here phase is reconstructed entirely within torch's griffin lim implementation.

https://pytorch.org/audio/main/generated/torchaudio.transforms.GriffinLim.html

In tasks such as source separation, often the solution converges much more quickly/becomes better when using the mixture phase for the estimation of the source audio output. So it would be cool if another parameter could be added to the function allowing you to optionally pass in an initial guess of the phase.

This functionality exists in librosa's implementation of Griffin Lim, where if the function parameter 'init' is passed None, the phase is initialized from input spectrogram (which must now phase).

https://librosa.org/doc/latest/generated/librosa.griffinlim.html

Alternatives

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant