Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] what is the difference between ManagedCollisionEmbeddingCollection and ITEPEmbeddingBagCollection #2473

Open
tiankongdeguiji opened this issue Oct 5, 2024 · 5 comments

Comments

@tiankongdeguiji
Copy link
Contributor

What is the difference between ManagedCollisionEmbeddingCollection and ITEPEmbeddingBagCollection, and when should I use ManagedCollisionEmbeddingCollection versus ITEPEmbeddingBagCollection?

@tiankongdeguiji
Copy link
Contributor Author

Hi, @henrylhtsang @joshuadeng @PaulZhang12 @TroyGarden can you see this problem?

@henrylhtsang
Copy link
Contributor

@YLGH any idea?

@tiankongdeguiji
Copy link
Contributor Author

hi, @YLGH can you see this problem?

@PaulZhang12
Copy link
Contributor

Hi @tiankongdeguiji, ManagedCollisionEmbeddingCollection is meant to represent ZCH embeddings, while ITEPEmbeddingBagCollection refers to pruning embeddings during training for memory savings.

@tiankongdeguiji
Copy link
Contributor Author

hi, @PaulZhang12 , does eviction in ManagedCollisionEmbeddingCollection correspond to pruning in ITEPEmbeddingBagCollection? Additionally, I believe ManagedCollisionEmbeddingCollection is also memory-efficient because it eliminates the need for a large hash size to prevent hash collisions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants