Fix clipped render when using geometry generator symbol in layout items #58926
+201
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
troopa81
reviewed
Oct 1, 2024
That's not trivial either, we'd need to set it for all subsymbols for the symbol. The flag is less code 😁
I thought about that, but I'm concerned that it might cause a new regression if someone has symbology designed around the extent being available. |
troopa81
reviewed
Oct 2, 2024
Comment on lines
+1563
to
+1566
| if ( clippingEnabled && context.testFlag( Qgis::RenderContextFlag::DisableSymbolClippingToExtent ) ) | ||
| { | ||
| clippingEnabled = false; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if ( clippingEnabled && context.testFlag( Qgis::RenderContextFlag::DisableSymbolClippingToExtent ) ) | |
| { | |
| clippingEnabled = false; | |
| } | |
| clippingEnabled &= !context.testFlag( Qgis::RenderContextFlag::DisableSymbolClippingToExtent ) |
Cosmetic proposal. less code, better readability. We could also group all other conditions related to this boolean, but that's not mandatory.
troopa81
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58909