Filter for text data not worked #315
Comments
|
This actually happens in all filters and caused by the fact the background of the filter is now invisible, so every time you click on the text box to insert your text it thinks you click outside the filter and closes it. I'm working on a pull request to fix that. |
|
Found the bug and fixed it in this pull request - #318 Maintainers - can you please review and if it looks ok merge and release a new qgrid version? Thanks. |
richardlin047
pushed a commit
to richardlin047/modin-spreadsheet
that referenced
this issue
Jan 5, 2021
|
This issue is also present for numerical filters and is not completely fixed with @ofirbit 's PR. Adding this commit(richardlin047@19e76a1) along with the #318 should fix the numerical filter display issues too. |
richardlin047
added a commit
to modin-project/modin-spreadsheet
that referenced
this issue
Feb 1, 2021
* fix: quantopian#315 - filters dont work and poorly displayed * FIX-315: Numerical filter label display * Add basic compatibility with modin. Fails some tests but UI mostly works. The filtering is weird. * Handle empty modin dataframe indexing * Add compatibility with pandas dataframe in addition to modin * Modify filter to work on partial NaN columns * Record all events in widget * Record history of functions applied to dataframe * Record messages sent from client to widget * Add feature to apply transformation history to new df * Try to fix all NaN column filter * Add notebook with working code examples * Create Jupyter cell with df history python code * Add transformation name to and format history code * Ignore active filter for toolbar and add/remove rows * Add clear history API and button * Add handler attr to toolbar button and make button event optional * Add reset filters functionality and button * Add reset sort functionality and button * Move record transformation after transformation completed * Move reset_sort case into function * Add reset_filters API * Move reset all filters command before update sort and table * Change comment * Remove test ipynb * Remove pytest log file * Remove pd_json helper and only use df.to_json * Import pandas as pandas not pd2 * Clean up comments and TODOs * Remove commented code that disables toolbar when filter is active * Format python code with black Co-authored-by: Ofir Yagil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Environment
Manjaro Linux x86_64
$ python --versionPython 3.8.2
pip,conda, orother (please explain))pip
$ pip freezeor$ conda list(please include qgrid, notebook, and jupyterlab versions)alembic==1.4.2
amqp==2.5.2
anytree==2.8.0
apache-airflow==1.10.10
apispec==1.3.3
apparmor==2.13.4
appdirs==1.4.3
application-utility==1.3.2
apriori==1.0.0
argcomplete==1.11.1
asn1crypto==1.3.0
astroid==2.3.3
astropy==4.0.1.post1
attrs==19.3.0
autopep8==1.5.2
Babel==2.8.0
backcall==0.1.0
bauh==0.9.0
bcrypt==3.1.7
Beaker==1.11.0
beautifulsoup4==4.9.0
billiard==3.6.3.0
bleach==3.1.4
bokeh==2.0.2
branca==0.3.1
Brotli==1.0.7
bs4==0.0.1
btrfsutil==1.2.0
CacheControl==0.12.6
cached-property==1.5.1
cachetools==4.1.0
cairocffi==1.1.0
CairoSVG==2.4.2
cattrs==0.9.2
celery==4.4.2
ceph-volume==1.0.0
cephfs==2.0.0
cephfs-shell==0.0.1
cffi==1.14.0
chardet==3.0.4
chrome-gnome-shell==0.0.0
click==7.1.1
click-plugins==1.1.1
cligj==0.5.0
cloudpickle==1.4.0
colorama==0.4.3
colorcet==2.0.2
colorlog==4.0.2
configparser==3.5.3
confuse==1.1.0
contextlib2==0.6.0.post1
croniter==0.3.31
cryptography==2.9.2
cssselect2==0.3.0
cupshelpers==1.0
cycler==0.10.0
dash==1.12.0
dash-core-components==1.10.0
dash-html-components==1.0.3
dash-renderer==1.4.1
dash-table==4.7.0
dask==2.15.0
datashader==0.10.0
datashape==0.5.2
DAWG-Python==0.7.2
decorator==4.4.2
defusedxml==0.6.0
dill==0.3.1.1
distlib==0.3.0
distributed==2.15.1
distro==1.5.0
duplicity==0.8.12.0
entrypoints==0.3
evdev==1.3.0
fake-useragent==0.1.11
fasteners==0.15
Fiona==1.8.13.post1
flake8==3.7.9
Flask==1.1.2
Flask-Admin==1.5.4
Flask-AppBuilder==2.3.2
Flask-Babel==1.0.0
Flask-Caching==1.3.3
Flask-Compress==1.5.0
Flask-JWT-Extended==3.24.1
Flask-Login==0.4.1
Flask-OpenID==1.2.5
Flask-SQLAlchemy==2.4.1
flask-swagger==0.2.13
Flask-WTF==0.14.3
flower==0.9.4
folium==0.10.1
fsspec==0.7.3
funcsigs==1.0.2
future==0.18.2
GDAL==3.0.4
geopandas==0.7.0
gestures==0.2.2
gitdb==4.0.4
GitPython==3.1.1
google-api-core==1.16.0
google-api-python-client==1.8.0
google-auth==1.11.3
google-auth-httplib2==0.0.3
googleapis-common-protos==1.51.0
gpg==1.13.1
graphviz==0.13.2
gufw==20.4.0
gunicorn==19.10.0
HeapDict==1.0.1
html5lib==1.0.1
htmlmin==0.1.12
httplib2==0.17.3
humanize==0.5.1
idna==2.9
ImageHash==4.1.0
imageio==2.8.0
ipykernel==5.2.0
ipyleaflet==0.12.4
ipython==7.13.0
ipython-genutils==0.2.0
ipywidgets==7.5.1
iso8601==0.1.12
isort==4.3.21
itsdangerous==1.1.0
jedi==0.15.2
Jinja2==2.11.2
joblib==0.14.1
json-merge-patch==0.2
json5==0.9.4
jsonschema==3.2.0
jupyter-client==6.1.3
jupyter-core==4.6.3
jupyterlab==2.1.2
jupyterlab-git==0.20.0
jupyterlab-server==1.1.1
kiwisolver==1.2.0
kombu==4.6.8
layoutswitcherlib==0.8.8
lazy-object-proxy==1.4.3
lensfun==0.3.95
LibAppArmor==2.13.4
librabbitmq==2.0.0
llvmlite==0.32.0
locket==0.2.0
lockfile==0.12.2
louis==3.13.0
lutris==0.5.6
lxml==4.5.0
Mako==1.1.2
mallard-ducktype==1.0.2
Markdown==2.6.11
MarkupSafe==1.1.1
marshmallow==2.21.0
marshmallow-enum==1.5.1
marshmallow-sqlalchemy==0.22.3
matplotlib==3.2.1
mccabe==0.6.1
missingno==0.4.2
mistune==0.8.4
monotonic==1.5
msgpack==1.0.0
multipledispatch==0.6.0
munch==2.5.0
nbconvert==5.6.1
nbdime==2.0.0
nbformat==5.0.5
networkx==2.4
notebook==6.0.3
npyscreen==4.10.5
numba==0.49.0
numpy==1.18.2
oauth2client==4.1.3
ordered-set==3.1.1
OWSLib==0.19.2
packaging==20.3
pacman-mirrors==4.16.4
pandas==1.0.3
pandas-profiling==2.6.0
pandocfilters==1.4.2
param==1.9.3
paramiko==2.7.1
parso==0.6.2
partd==1.1.0
patsy==0.5.1
pendulum==1.4.4
pep517==0.8.2
pexpect==4.8.0
phik==0.9.11
pickleshare==0.7.5
Pillow==6.2.1
plotly==4.7.0
pluggy==0.13.1
ply==3.11
postgres==3.0.0
prison==0.1.3
progress==1.5
prometheus-client==0.7.1
prompt-toolkit==3.0.5
protobuf==3.11.4
psutil==5.7.0
psycopg2==2.8.5
psycopg2-binary==2.8.5
psycopg2-pool==1.1
ptyprocess==0.6.0
pwquality==1.4.2
pyaml==20.4.0
pyasn1==0.4.8
pyasn1-modules==0.2.8
pycairo==1.19.1
pycodestyle==2.5.0
pycparser==2.20
pyct==0.4.6
pycups==2.0.1
pycurl==7.43.0.5
pydocstyle==5.0.2
PyDrive==1.3.1
pyflakes==2.1.1
Pygments==2.6.1
PyGObject==3.36.0
PyJWT==1.7.1
pylint==2.4.4
pymorphy2==0.8
pymorphy2-dicts==2.4.393442.3710985
PyNaCl==1.3.0
pyparsing==2.4.7
pyproj==2.6.0
PyQt5==5.14.2
PyQt5-sip==12.7.2
PyQtWebEngine==5.14.0
pyrsistent==0.16.0
PySocks==1.7.1
python-daemon==2.1.2
python-dateutil==2.8.1
python-editor==1.0.4
python-jsonrpc-server==0.3.4
python-pptx==0.6.18
python-xlib==0.27
python3-openid==3.1.0
pytoml==0.1.21
pytz==2019.3
pytzdata==2019.3
PyWavelets==1.1.1
pyxdg==0.26
PyYAML==5.3.1
pyzmq==19.0.0
Editable install with no version control (qgrid==1.3.1)
-e /home/volokzhanin/.local/lib/python3.8/site-packages
QScintilla==2.11.4
rados==2.0.0
rbd==2.0.0
reportlab==3.5.42
requests==2.23.0
retrying==1.3.3
rgw==2.0.0
rope==0.16.0
rsa==4.0
scikit-image==0.16.2
scikit-learn==0.22.2.post1
scipy==1.4.1
seaborn==0.10.1
selenium==3.141.0
Send2Trash==1.5.0
setproctitle==1.1.10
Shapely==1.7.0
sip==4.19.22
six==1.14.0
sklearn==0.0
smmap==3.0.2
snowballstemmer==2.0.0
sortedcontainers==2.1.0
soupsieve==1.9.5
SQLAlchemy==1.3.16
SQLAlchemy-JSONField==0.9.0
SQLAlchemy-Utils==0.36.3
statsmodels==0.11.1
stem==1.8.0
swifter==0.304
tabulate==0.8.7
tangled-up-in-unicode==0.0.4
tblib==1.6.0
team==1.0
tenacity==4.12.0
termcolor==1.1.0
terminado==0.8.3
testpath==0.4.4
text-unidecode==1.2
thrift==0.13.0
tinycss2==1.0.2
toml==0.10.0
toolz==0.10.0
torbrowser-launcher==0.3.2
torch==1.4.0
tornado==5.1.1
tqdm==4.45.0
traitlets==4.3.3
traittypes==0.2.1
typing-extensions==3.7.4.2
tzlocal==1.5.1
ufw==0.36
ujson==1.35
unicodecsv==0.14.1
uritemplate==3.0.1
urllib3==1.25.9
vine==1.3.0
visions==0.4.1
wcwidth==0.1.9
webencodings==0.5.1
Werkzeug==0.16.1
widgetsnbextension==3.5.1
wrapt==1.11.2
WTForms==2.2.1
xarray==0.15.1
xcffib==0.9.0
XlsxWriter==1.2.8
yapf==0.30.0
zict==2.0.0
zope.deprecation==4.4.0
$ jupyter labextension listJupyterLab v2.1.2
Known labextensions:
app dir: /home/volokzhanin/.local/share/jupyter/lab
@jupyter-widgets/jupyterlab-manager v2.0.0 enabled OK
@jupyterlab/geojson-extension v2.0.1 enabled OK
@jupyterlab/git v0.20.0 enabled OK
@jupyterlab/latex v2.0.0 enabled OK
jupyterlab-drawio v0.7.0 enabled OK
jupyterlab-plotly v4.7.0 enabled OK
nbdime-jupyterlab v2.0.0 enabled OK
qgrid2 v1.1.3 enabled OK
Uninstalled core extensions:
@8080labs/qgrid
qgrid
Description of Issue
I'm installed qgrid, but filters for string data not work. When I choose filter and start print text the field of filter is disappeared and do not filter rows. Check boxes for rows is work at the same time.
Reproduction Steps
import qgrid
import pandas as pd
df = pd.DataFrame({'test' : ['sdvg', 'svbsv', 'efgw']})
qgrid.show_grid(df)
What steps have you taken to resolve this already?
Installed and uninstalled qgrid, jupyterlab, jupyter widgets for different versions. Result is not reached.
Anything else?
...
The text was updated successfully, but these errors were encountered: