Serializeing Value::Tag(1, Box::new(Value::...) hangs

[barries]

I'm trying to serialize a timestamped Message using a CBOR tag 1 containing an f64.

This code, which I am attempting based on reading cbor4ii's source and may not be correct, hangs. I also tried it with a Value::Integer(0).

#[derive(Serialize)]                  
struct Message (                      
    cbor4ii::core::Value, // timestamp
    String,                           
);                                    

let msg = Message(                                                                                
    cbor4ii::core::Value::Tag(1, Box::new(cbor4ii::core::Value::Float(0.0f64))),                  
    "Hello World!".to_string(),                                                                   
);                                                                                                
let _ = self.cbor_file.write(to_vec(vec!(), &msg).expect("CBOR serialization failed").as_slice());

Removing the Tag() wrapper, like so, works correctly:

let msg = Message(                                                                      
    /*cbor4ii::core::Value::Tag(1, Box::new(*/cbor4ii::core::Value::Float(0.0f64)/*))*/,
    "Hello World!".to_string(),                                                         
);                                                                                      
let _ = self.cbor_file.write(to_vec(vec!(), &msg).expect("CBOR serialization failed").as_slice());

[quininer]

to_vec returned an error because serializing Tag is not supported. see https://github.com/quininer/cbor4ii/blob/master/src/core.rs#L172

this will cause your program to panic because you are using .expect(). The cause of hangs may be caused by your panic hook.

[quininer]

I won't implement it yet, because Tag behaves differently depending on the value, and serde's serialization model does not map this well.

If anyone has a better way of doing it I'd be happy to merge it.

[barries]

Thanks! Makes sense.

…

On Wed, Nov 6, 2024, 10:27 PM quininer ***@***.***> wrote: to_vec returned an error because serializing Tag is not supported. see https://github.com/quininer/cbor4ii/blob/master/src/core.rs#L172 this will cause your program to panic because you are using .expect(). The cause of hangs may be caused by your panic hook. — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEXVAYSY4TIGWDPLRCLZ7DZ7LMZBAVCNFSM6AAAAABRJVNATGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRRGI2DGNBZGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>