Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce "strict" mode for bigint setting #334

Open
7 tasks
nbenn opened this issue Dec 18, 2023 · 1 comment
Open
7 tasks

Introduce "strict" mode for bigint setting #334

nbenn opened this issue Dec 18, 2023 · 1 comment

Comments

@nbenn
Copy link
Member

nbenn commented Dec 18, 2023

Commit 641ec8b on branch dev for adbi adds experimental support for "strict" bigint options: "integer-strict" and "numeric-strict" both error on lossy data conversions (due to overflow or rounding).

Using "integer-strict" as default causes issues with tests:

  • data_64_bit_numeric
  • data_64_bit_numeric_warning
  • data_64_bit_lossless
  • arrow_read_table_arrow

Further issues might exist but currently do not reach the point where this issue comes up. Candidates include

  • roundtrip_64_bit_numeric
  • roundtrip_64_bit_character
  • roundtrip_64_bit_roundtrip
@krlmlr
Copy link
Member

krlmlr commented Dec 18, 2023

Thanks for the heads-up, looks good!

We should expand the specs here. It will take some time because I want to inline the checks first. The skips in adbi are fine for now, except I don't see why arrow_read_table_arrow would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants