Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't expand the limayaml structure with private fields #7629

Open
jandubois opened this issue Oct 11, 2024 · 0 comments
Open

Don't expand the limayaml structure with private fields #7629

jandubois opened this issue Oct 11, 2024 · 0 comments
Assignees
Labels
area/kubernetes k8s and related, like traefik component/lima Issues related to lima and qemu kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Milestone

Comments

@jandubois
Copy link
Member

Lima is going to switch to strict YAML validation, refusing lima.yaml files that contain unknown keys.

Rancher Desktop stores the k3s version in a custom field:

// The rest of the keys are not used by lima, just state we keep with the VM.
k3s?: {
version: string;
}

This should be moved to either an env variable, or to a provision script.

The custom field should be removed from existing instances during Rancher Desktop upgrade.

@jandubois jandubois added component/lima Issues related to lima and qemu kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API labels Oct 11, 2024
@jandubois jandubois added this to the 1.17 milestone Oct 11, 2024
@jandubois jandubois self-assigned this Oct 11, 2024
@jandubois jandubois added the area/kubernetes k8s and related, like traefik label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubernetes k8s and related, like traefik component/lima Issues related to lima and qemu kind/quality quality improvements, refactoring, Automation via CI, E2E, Integration, CLI or REST API
Projects
None yet
Development

No branches or pull requests

1 participant