Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Compare Changes" doesn't match values.yaml #30

Open
lindhe opened this issue Sep 14, 2023 · 1 comment
Open

"Compare Changes" doesn't match values.yaml #30

lindhe opened this issue Sep 14, 2023 · 1 comment

Comments

@lindhe
Copy link

lindhe commented Sep 14, 2023

Using this repo as source, if I go and create a new repo, choose "cluster-template" and click "Compare Changes", the diff looks like this:

nodepools.0 is added

As we can see, it has added the object nodepools with the field '0'. So the type of nodepools is clearly object.

This is in contrast with the values.yaml where nodepools is a list of objects:

nodepools:
- etcd: true

I assume that the intention here was to "create the list nodepools with x as the first element", not to "create the object nodepools with the field '0' with value x".

I haven't tried it, but it would surprise me greatly if it works with having nodepools as either an object or a list.

Ideally, I would like to have a menu for configuring nodepools similar to the one when creating a VMware vSphere cluster without templates:

nodepool menu without templates

@lindhe
Copy link
Author

lindhe commented Sep 15, 2023

Seems like array type answers are not yet implemented: rancher/rancher#13952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant