Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy for managing upstream churn #317

Open
JSKenyon opened this issue Jan 25, 2024 · 4 comments
Open

Strategy for managing upstream churn #317

JSKenyon opened this issue Jan 25, 2024 · 4 comments

Comments

@JSKenyon
Copy link
Collaborator

This is a high level but persistent problem. Due to the somewhat advanced usage of various dask/dask-ms/numba features in QuartiCal, release versions can easily be broken by upstream changes. The simple solution to this problem is to use a tool like poetry to freeze in known working versions on release. This is more robust to upstream change, but more brittle in the long term as it means installing QC as a dependency/in the same environment as another package may become difficult.

This issue is here to help me gather my thoughts/solicit opinions from users.

@bennahugo
Copy link
Collaborator

bennahugo commented Jan 25, 2024 via email

@sjperkins
Copy link
Member

installing QC as a dependency/in the same environment as another package may become difficult

In general I think users should be discouraged from doing this, even though they might be surprised that they shouldn't!

@JSKenyon
Copy link
Collaborator Author

I think that I am gravitating towards using poetry for end-user installations. The lock file should ensure that each release remains installable regardless of upstream churn. The project will remain pip installable with the caveat that the looser dependencies may lead to breakages. I am tempted to drop support for Python3.8 as it results in very stale versions in the lock file (due to upstream deprecations). I think that this is likely fine as alternative Python versions are available via deadsnakes and QC should typically be installed in a virtual environment.

@JSKenyon
Copy link
Collaborator Author

Once again, I have convinced myself that poetry doesn't really resolve the problem as poetry.lock is not honoured when installing from PyPI. It may be part of the solution though. I think that I am going to adopt the following strategy:

  1. Use poetry with only minimum version specifications in pyproject.toml.
  2. Use the resulting poetry.lock to establish the most up-to-date versions which can be installed.
  3. Use the results of 2 to pin the maximum versions in pyproject.toml on each release.

I believe that the above strategy should produce relatively robust PyPI packages without being too strict. It also keeps things simple for users while simultaneously giving us a way to sync dev environments (if required).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants