Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Some client-go logs are not in JSON format #2512

Open
1 of 2 tasks
kevin85421 opened this issue Nov 7, 2024 · 1 comment · May be fixed by #2535
Open
1 of 2 tasks

[Feature] Some client-go logs are not in JSON format #2512

kevin85421 opened this issue Nov 7, 2024 · 1 comment · May be fixed by #2535
Assignees
@fscnick
Labels
1.3.0 enhancement New feature or request good first issue Good for newcomers logging

Comments

@kevin85421
Copy link
Member

kevin85421 commented Nov 7, 2024 •
edited
Loading

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Some logs from client-go are not in JSON format. For example,

Screenshot 2024-11-06 at 9 25 39 PM

https://github.com/kubernetes/client-go/blob/v0.31.2/tools/leaderelection/leaderelection.go#L254

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@kevin85421 kevin85421 added enhancement New feature or request triage 1.3.0 logging good first issue Good for newcomers and removed triage labels Nov 7, 2024
@kevin85421 kevin85421 mentioned this issue Nov 7, 2024
Open
2 tasks
@ray-project ray-project deleted a comment from EagleLo Nov 7, 2024
@fscnick
Copy link
Contributor

fscnick commented Nov 7, 2024

Hi @kevin85421, I'd like to help with this issue.

@fscnick fscnick linked a pull request Nov 12, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fscnick fscnick

Labels
1.3.0 enhancement New feature or request good first issue Good for newcomers logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

some logs are not json format fscnick/kuberay
2 participants
@fscnick @kevin85421