Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatasetCore#match returns Dataset or DatasetCore? #55

Open
RubenVerborgh opened this issue Sep 8, 2019 · 1 comment
Open

DatasetCore#match returns Dataset or DatasetCore? #55

RubenVerborgh opened this issue Sep 8, 2019 · 1 comment

Comments

@RubenVerborgh
Copy link
Member

The DatasetCore interface description says it returns Dataset, but the description of match says This method always returns a new DatasetCore.

My suggestion would be to make it return a DatasetCore, and to make the equivalent method in Dataset return a Dataset.

@retog
Copy link

retog commented May 9, 2020

I think the same applies to the add and delete methods. The advantage of separating DatasetCore and Dataset is that DatasetCore can more easily be implemented and a decorator can be used tomake it a full-fledged Dataset, this advantage is lost if implementors of DatasetCore have to implement Dataset anyway to correctly implemenet the methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants