Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Validation of Booleans #433

Open
RichardWarburton opened this issue Jun 9, 2021 · 0 comments
Open

Improve Validation of Booleans #433

RichardWarburton opened this issue Jun 9, 2021 · 0 comments
Assignees

Comments

@RichardWarburton
Copy link
Contributor

FIX only allows Y and N values for boolean fields. Currently we just check if the field value is Y. Ideally we want a way to validate boolean fields.

One option would be to throw an exception on the getter. Normally in Artio codecs we have methods for checking whether fields are valid rather than just throwing. So we could have a field method boolean foo() and possibly supplementary methods char fooValue() and boolean isValidFoo().

No matter the API we probably need to store the char value for booleans, rather than just a boolean.

@RichardWarburton RichardWarburton self-assigned this Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant