[Bug] hgetall returns an empty object rather than undefined if the key does not exist

[shiruken]

Info

If a given key does not exist, hgetall returns an empty object rather than undefined as the typehint suggests.

devvit/packages/public-api/src/types/redis.ts

Line 511 in fb29ce4

hgetall(key: string): Promise<Record<string, string> | undefined>;

This object unfortunately evaluates as truthy and therefore requires the user to check if keys are present in the object to determine whether the hash actually existed.

This appears to differ from the current behavior of both get and hget.

Example

const foo = await context.redis.hgetall('foo'); // no hash actually exists at key 'foo'
if (foo) {
  console.log('foo is true'); // this will be output
}

console.log(foo); // [Object object]