You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 17, 2020. It is now read-only.
We use recursive promises in a couple places in the amqp backend. (setup and register functions). We should check if we have to trampoline them.
From the top of my head Iris only uses this recursion to keep the connection alive, thou only increasing the stack on connection loss. This means that the memory leaked in iris is negligible as the number of times the connection needs to drop for this to be noticeable it's likely to be never reached. (2-3Mb every 10k recursive calls)
Background and relevant links:
This problem was spotted while writing a new data transfer tool that was using recursive pagination to call the database using promises over Iris. The main issue was not in iris but the recursive call itself.
We use recursive promises in a couple places in the amqp backend. (setup and register functions). We should check if we have to
trampoline
them.From the top of my head Iris only uses this recursion to keep the connection alive, thou only increasing the stack on connection loss. This means that the memory leaked in iris is negligible as the number of times the connection needs to drop for this to be noticeable it's likely to be never reached. (2-3Mb every 10k recursive calls)
Background and relevant links:
This problem was spotted while writing a new data transfer tool that was using recursive pagination to call the database using promises over Iris. The main issue was not in iris but the recursive call itself.
The text was updated successfully, but these errors were encountered: