"shx.el passes byte-compilation" test fails on Emacs 29.1

[Apteryks]

Hi,

Currently, on GNU Guix (see: https://ci.guix.gnu.org/build/3331960/log/raw)

starting phase `check'
✔ shx-tokenize works with apostrophes.
✔ shx-tokenize works with partial apostrophes.
✔ shx-tokenize returns nil when quoting doesn't match.
✔ shx-tokenize works with apostrophes and quotation marks.
✔ shx-tokenize works with escaped spaces.
✔ shx-tokenize works with escaped quotation marks.
✔ shx-tokenize works with escaped characters
✔ shx-tokenize works with a directory specified.
✔ shx--safe-as-markup-p recognizes unsafe command
✔ shx--safe-as-markup-p recognizes a safe command
✔ shx--safe-as-markup-p handles undocumented command
✔ shx--replace-from-list acts sequentially
✔ shx--replace-from-list performs the correct replacements
✔ shx.el passes checkdoc
✔ shx-cmd-syntax recognizes command with arguments
✔ shx-cmd-syntax recognizes alphabetical command names
✔ shx-cmd-syntax recognizes hyphenated command names
✔ shx--quote-regexp matches escaped regexps correctly
✔ shx--quote-regexp matches unescaped regexps correctly

In toplevel form:
shx.el:99:2: Warning: custom-declare-variable `shx-max-input' docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In shx-send-input-or-copy-line:
shx.el:168:47: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
shx.el:168:62: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In shx--propertize-prompt:
shx.el:215:7: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.

In shx--parse-output-for-markup:
shx.el:241:15: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
shx.el:242:15: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In shx--search-forward:
shx.el:274:13: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In shx-tokenize-filenames:
shx.el:354:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In shx--current-prompt:
shx.el:381:11: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.

In shx--current-input:
shx.el:390:5: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In shx-insert-plot:
shx.el:578:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In shx--shell-quote-no-quotation-marks:
shx.el:594:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In shx--asynch-sentinel:
shx.el:661:15: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
shx.el:662:36: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In shx-cmd-grep:
shx.el:842:2: Warning: docstring has wrong usage of unescaped single quotes (use \= or different quoting)

In shx-flash-prompt:
shx.el:1152:59: Warning: ‘point-at-eol’ is an obsolete function (as of 29.1); use ‘line-end-position’ or ‘pos-eol’ instead.

In shx--with-shx-cwd:
shx.el:1176:35: Warning: ‘point-at-bol’ is an obsolete function (as of 29.1); use ‘line-beginning-position’ or ‘pos-bol’ instead.
✘ shx.el passes byte-compilation
✔ shx--shell-command finds the default shell
✔ shx--get-timer-list is empty
✔ shx--shx-timer-list grows by 1
✔ shx--get-timer-list becomes empty
✔ shx--shell-quote-no-quotation-marks escapes string
✔ shx-el passes check-declare-file
✔ shx-cat concatenates strings correctly
✔ shx-cat propertizes text correctly
✔ shx--get-user-cmd returns nil for empty string
✔ shx--get-user-cmd returns command with correct prefix
✔ shx-tokenize-filenames works with relative and absolute paths.
error: in phase 'check': uncaught exception:
%exception #<&invoke-error program: "emacs" arguments: ("--batch" "--quiet" "--script" "test/script.el") exit-status: 1 term-signal: #f stop-signal: #f> 
phase `check' failed after 0.6 seconds

This is happening using the latest commit of the master branch.

[Apteryks]

Will send a simple fix.

[Apteryks]

Another, unrelated patch that lives in the Guix tree is:

(add-after 'unpack 'appease-checkdoc
              (lambda _
                (substitute* "shx.el"
                  (("Toggle shx-mode on") "Toggle `shx-mode' on"))))