From 0b778c592b01356dd51812faed40916c32c6a565 Mon Sep 17 00:00:00 2001 From: Jakob Blomer Date: Tue, 15 Oct 2024 11:51:30 +0200 Subject: [PATCH 1/2] [NFC][ntuple] add clarifying comments --- tree/ntuple/v7/test/ntuple_view.cxx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tree/ntuple/v7/test/ntuple_view.cxx b/tree/ntuple/v7/test/ntuple_view.cxx index 2ba07a6682b44..f782e26f115a7 100644 --- a/tree/ntuple/v7/test/ntuple_view.cxx +++ b/tree/ntuple/v7/test/ntuple_view.cxx @@ -293,6 +293,7 @@ TEST(RNTuple, ViewFrameworkUse) auto model = RNTupleModel::Create(); auto ptrPx = model->MakeField("px"); auto ptrPy = model->MakeField("py"); + // The trigger pages make a whole in the on-disk layout that is not (purposefully) read model->MakeField("trigger"); auto ptrPz = model->MakeField("pz"); @@ -346,6 +347,8 @@ TEST(RNTuple, ViewFrameworkUse) } // Ensure that cluster prefetching and smearing of read requests works + // Note that "nClusterLoaded" is the number of _partial_ clusters preloaded from storage. Because we read + // from the first cluster first px and then py, we'll call two times `LoadCluster()` on the first cluster. EXPECT_LT(reader->GetDescriptor().GetNClusters(), reader->GetMetrics().GetCounter("RNTupleReader.RPageSourceFile.nClusterLoaded")->GetValueAsInt()); EXPECT_LT(reader->GetMetrics().GetCounter("RNTupleReader.RPageSourceFile.nReadV")->GetValueAsInt(), From 9532e4f3e7bc6fd87e25beec2108d422e555d862 Mon Sep 17 00:00:00 2001 From: Jakob Blomer Date: Tue, 15 Oct 2024 13:32:36 +0200 Subject: [PATCH 2/2] [NFC][ntuple] fix typo in code comment Co-authored-by: Jonas Hahnfeld --- tree/ntuple/v7/test/ntuple_view.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tree/ntuple/v7/test/ntuple_view.cxx b/tree/ntuple/v7/test/ntuple_view.cxx index f782e26f115a7..92746dd29b306 100644 --- a/tree/ntuple/v7/test/ntuple_view.cxx +++ b/tree/ntuple/v7/test/ntuple_view.cxx @@ -293,7 +293,7 @@ TEST(RNTuple, ViewFrameworkUse) auto model = RNTupleModel::Create(); auto ptrPx = model->MakeField("px"); auto ptrPy = model->MakeField("py"); - // The trigger pages make a whole in the on-disk layout that is not (purposefully) read + // The trigger pages make a hole in the on-disk layout that is not (purposefully) read model->MakeField("trigger"); auto ptrPz = model->MakeField("pz");