Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] ccache in pre-release #667

Open
tylerjw opened this issue May 2, 2021 · 7 comments
Open

[question] ccache in pre-release #667

tylerjw opened this issue May 2, 2021 · 7 comments

Comments

@tylerjw
Copy link
Contributor

tylerjw commented May 2, 2021

In our testing it seemed like pre-release wasn't using ccache but then I read the code for the pre-release test and I found these lines:

if ! [ -d "$WORKSPACE/home/.ccache" ]; then
ici_asroot mkdir -p "$WORKSPACE/home/.ccache"
fi

These don't reference the CCACHE_DIR but instead check for the existance of a specific directory. Does this work if I have the ccache directory somewhere else?

@mathias-luedtke
Copy link
Member

This was only a work-around for ros-infrastructure/ros_buildfarm#695 and might not be needed anymore.

Does this work if I have the ccache directory somewhere else?

I am not sure if ros_buildfarm supports this (ros-infrastructure/ros_buildfarm#582 wasn't merged yet).

@mathias-luedtke
Copy link
Member

At the moment $WORKSPACE is a temporary directroy, but we could put it into $BASEDIR as well.
Then you could cache it from there..

@tylerjw
Copy link
Contributor Author

tylerjw commented May 3, 2021

Maybe WORKSPACE could be set to be BASEDIR if it was defined and then we could cache the ccache directory in there?

@mathias-luedtke
Copy link
Member

Actually, CCACHE_DIR should work..

if [ -n "${CCACHE_DIR}" ]; then
ici_forward_mount CCACHE_DIR rw "$WORKSPACE/home/.ccache"
CCACHE_DIR= # prevent cachedir from beeing added twice
fi

@mathias-luedtke
Copy link
Member

The ccache is forwarded properly, but it looks like ros_buildfarm does not use it anymore (ros-infrastructure/ros_buildfarm#844).

@mathias-luedtke
Copy link
Member

See ros-infrastructure/ros_buildfarm#876 as well

@mathias-luedtke
Copy link
Member

@tylerjw: please test #670. It should work with CCACHE_DIR. BASEDIR is now supported as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants