New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linter rule to avoid shadowing builtins #302

Open

nathanjmcdougall opened this issue Aug 20, 2024 · 0 comments · May be fixed by #303

Contributor

nathanjmcdougall commented Aug 20, 2024

In #274, I inadvertently shadowed the builtin type in my PR, which was caught in review.

It might be good to enable these ruff rules (category A from flake8-builtins):
https://docs.astral.sh/ruff/rules/#flake8-builtins-a
e.g.
https://docs.astral.sh/ruff/rules/builtin-variable-shadowing/

This would help automatically avoid this situation in the future.

The text was updated successfully, but these errors were encountered:

nathanjmcdougall linked a pull request

that will close this issue

Avoid shadowing builtins #303

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment