Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared input/output IDs shouldn't break apps even in devmode #4100

Open
gadenbuie opened this issue Jul 12, 2024 · 0 comments · May be fixed by #4101
Open

Shared input/output IDs shouldn't break apps even in devmode #4100

gadenbuie opened this issue Jul 12, 2024 · 0 comments · May be fixed by #4101

Comments

@gadenbuie
Copy link
Member

gadenbuie commented Jul 12, 2024 •
edited
Loading

In #4019 we downgraded the shared input/output ID error to a warning when not in devmode, which doesn't break deployed apps.

shiny/srcts/src/shiny/bind.ts

Lines 427 to 432 in 0b7fda7

// Only throw if we're in dev mode. Otherwise, just log a warning.
if (Shiny.inDevMode()) {
throw bindingValidity.error;
} else {
console.warn("[shiny] " + bindingValidity.error.message);
}

But the JavaScript error breaks apps run through devmode, while also showing an error message. Having run into this in the wild a few times now -- and given that we're trying to turn on devmode by default in more situations, like in the VS Code extension -- I would prefer the in-client warning be shown without breaking the app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Avoid throwing errors for shared input/output IDs rstudio/shiny
1 participant
@gadenbuie