Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Committed changes not visible - RBE shows old code #1879

Open
psyklopp opened this issue Aug 27, 2024 · 1 comment
Open

Committed changes not visible - RBE shows old code #1879

psyklopp opened this issue Aug 27, 2024 · 1 comment

Comments

@psyklopp
Copy link
Contributor

psyklopp commented Aug 27, 2024

I have added a TLDR; section at the end. Apologies if this is a very simple error but I just wanted to report this. I am still a beginner.

Issue

I added the following snippet of code - #1878 and the commits were merged.

    /* Compound types - Array and Tuple */

    // Array signature consists of Type T and length as [T; length].
    let my_array: [i32; 5] = [1, 2, 3, 4, 5];

    // Tuple is a collection of values of different types 
    // and is constructed using parentheses ().
    let my_tuple = (5u32, 1u8, true, -5.04f32);

But the changes are not visible in the code editor on the relevant page. We can check it here: 2. Primitives

I also fixed the workflow status on README.md but that is visible.

Similar Issue

May 16

// Incorrect comment

// `bottom_right.y` will be the same as `point.y` because we used that field
// from `point`

to

// Correct comment

// `bottom_right.y` will be the same as `another_point.y` because we used that field
// from `another_point`

June 6

But the same is not visible when we view the page online - 3.1 Structures

July 22

TLDR;

The .md file and the corresponding generated .html are different.

Check for line 60, 61 in 3.1 Structures .md file

They are not shown correctly on the website: https://doc.rust-lang.org/rust-by-example/custom_types/structs.html

Same for the page Primitives - primitives.md file

@psyklopp
Copy link
Contributor Author

Just a note: Generating RBE locally after mdbook build and mdbook serve, everything is visible correctly. The above issues do not appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant