Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspect miniz_oxide for antipatters and request Clippy lints #45

Open
Shnatsel opened this issue Nov 1, 2019 · 1 comment
Open

Inspect miniz_oxide for antipatters and request Clippy lints #45

Shnatsel opened this issue Nov 1, 2019 · 1 comment

Comments

@Shnatsel
Copy link
Member

Shnatsel commented Nov 1, 2019

miniz_oxide has undergone a significant safety improvement recently (see #2). It had plenty of avoidable unsafe code. We should look through the changes and request Clippy lints for the antipatterns that were fixed.

The commit range for safety fixes is from Frommi/miniz_oxide@7fc6d66 to Frommi/miniz_oxide@23a6759, both bounds inclusive.

For more info on requesting Clippy lints see #21.

@Shnatsel
Copy link
Member Author

Shnatsel commented Dec 8, 2019

Requested lint for read_unaligned() that's prevalent in the code and can be safely replaced: rust-lang/rust-clippy#4891

There is also a similar write_unaligned() pattern, we'll need to request a lint for it too: Frommi/miniz_oxide@7fc6d66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant