Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make rendered lines sharper #563

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

make rendered lines sharper #563

wants to merge 4 commits into from

Conversation

wflemingnz-retired
Copy link

closes #356

umarmohammed
umarmohammed reviewed Apr 24, 2020
View reviewed changes
projects/ngx-rxtimeline/src/lib/line/line.component.ts Outdated
@@ -10,6 +10,13 @@ import { Line } from '../core/line';
[attr.y2]="line.y2"
></svg:line>
`,
styles: [
`
line {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should go in the ngx-rxtimeline.component.scss? ViewEncapsulation for the root component is set to none so I don't think this style will be localised to this component.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, overlooked that we were doing it all that the top level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umarmohammed umarmohammed umarmohammed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make rendered lines sharper
2 participants
@wflemingnz-retired @umarmohammed