Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library request in cdnjs. #34

Open
Piicksarn opened this issue Oct 27, 2016 · 7 comments
Open

Library request in cdnjs. #34

Piicksarn opened this issue Oct 27, 2016 · 7 comments

Comments

@Piicksarn
Copy link

Hi ~
There's a library request in cdnjs, and we desire to contain rye .
However, I must to make a check for the files that we need to added.

The file i would like to add is:

lib/rye.js

Is that complete for the user? Or other files required?

Thanks for your great work ✨

Piicksarn

@ricardobeat
Copy link
Member

Hi @Piicksarn! The right files to add would be dist/rye.js and dist/rye-base.js, which are the result of running cake build + cake build --light, and not currently commited to the git repo.

Now I feel like updating this to use a package bundler :)

@Piicksarn
Copy link
Author

@ricardobeat ✨ ,
thanks! I'll update the pr which I send to cdnjs later.
Before that, would you mind to provide latest dist/rye.js, dist/rye-base.js on github and use git tags? Since I found the latest version of rye is 0.1.0 👉 http://ryejs.com/dist/rye-0.1.0.js, and cdnjs use git tags for library auto-update. If rye could use git tags, then the files contained in cdnjs will be updated automatically when the new versions released.
😃

@ricardobeat
Copy link
Member

@Piicksarn I'll see about updating it.

@WesSouza
Copy link
Contributor

@Piicksarn take a look at #37, would making the package npm-install-friendly help?

@ricardobeat
Copy link
Member

#37 has been merged, dist/rye-base.js and dist/rye.js are commited, and the library is now published on npm: http://npmjs.com/package/ryejs

@Piicksarn anything else needed from our side?

@Piicksarn
Copy link
Author

@ricardobeat ,
the license was ISC before, and now is MIT, so is that fine we discuss ryejs as double licenses with both "MIT" and "ISC", or only MIT license uses?

@WesSouza
Copy link
Contributor

@Piicksarn yes, our license is ISC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants