You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This library is not thread-safe and thus does not need synchronisation. All synchronized blocks and synchronised lists etc. should be removed/replaced.
Since the WebSocket implementation does use threads internally, we still need synchronisation between it and the public API surface. I see a couple of options:
Make everything synchronized.
Introduce an API to hand in a lock from the application that is being used for pretty much everything.
Get rid of the WebSocket threads and allow this library to be run single-threaded (my preference, mid-term).
Remove the WebSocket transport. Create a transport interface and let the application create its own WebSocket transport (my preference, long-term).
The text was updated successfully, but these errors were encountered:
This library is not thread-safe and thus does not need synchronisation. All
synchronized
blocks and synchronised lists etc. should be removed/replaced.Since the WebSocket implementation does use threads internally, we still need synchronisation between it and the public API surface. I see a couple of options:
synchronized
.The text was updated successfully, but these errors were encountered: