Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyrax::WorkingDirectory puts object in memory as string #1128

Closed
atz opened this issue Jun 3, 2017 · 2 comments
Closed

Hyrax::WorkingDirectory puts object in memory as string #1128

atz opened this issue Jun 3, 2017 · 2 comments

Comments

@atz
Copy link
Contributor

atz commented Jun 3, 2017

Hyrax::WorkingDirectory in the line:

copy_stream_to_working_directory(id, file.original_name, StringIO.new(file.content))

calling file.content (potentially) puts the entire file in memory at once. See ActiveFedora::File#content and the various behaviors based on different @content classes (local_or_remote_content and behaves_like_io?).

The point is that WorkingDirectory doesn't know whether it is getting in IO-like object, or an internal @ds_content, ldp_source.get.body or what. @jcoyne identified this problem in commit 5db7d0c with the line:

TODO: this causes a load into memory, which we'd like to avoid
@atz
Copy link
Contributor Author

atz commented Jun 5, 2017

See: samvera/hydra-derivatives#162

@no-reply
Copy link
Contributor

Closing this. We won't do directed work on this unless we can identify a related performance issue.

We're re-instating Skylight on Nurax to help identify performance and memory use issues, but also welcome active feedback from adopters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants