Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javapc's HoverTermSuite fails on JDK 21 #5318

Open
SethTisue opened this issue Jun 8, 2023 · 3 comments
Open

javapc's HoverTermSuite fails on JDK 21 #5318

SethTisue opened this issue Jun 8, 2023 · 3 comments

Comments

@SethTisue
Copy link
Contributor

SethTisue commented Jun 8, 2023

this came up in the Scala 2 community build:

-public interface java.util.List<E> extends java.util.SequencedCollection<E>
+public interface java.util.List<E> extends java.util.Collection<E>

https://scala-ci.typesafe.com/job/scala-2.13.x-jdk21-integrate-community-build/32/artifact/logs/metals-build.log

@SethTisue SethTisue changed the title HoverTermSuite fails on JDK 21 javapc's HoverTermSuite fails on JDK 21 Jun 8, 2023
@ckipp01
Copy link
Member

ckipp01 commented Jun 8, 2023

Thanks for the report @SethTisue, it looks like we don't account for differences in the JDK versions in the suite. It should be a fairly quick fix.

EDIT: Just adding a note in here to say that I haven't forgotten about this, just cs doesn't have any 21 versions yet, and that's what I use to get my Java. So as soon as that appears I'll look further at this.

@SethTisue
Copy link
Contributor Author

21's out and available

@ckipp01
Copy link
Member

ckipp01 commented Oct 28, 2023

21's out and available

Looks like @tgodzik started the work on #5758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants