Test this action #14
Draft
Test this action #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but no real tests yet
bsipocz
reviewed
Jun 4, 2024
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Use the hashes instead, see https://github.com/scientific-python/upload-nightly-action/pull/81/files
There was a problem hiding this comment.
OK... but probably via batch PR. Looks like Dependabot is ok with hashes. dependabot/dependabot-core#4691
bsipocz
reviewed
Jun 4, 2024
| # the `language` matrix defined below to confirm you have the correct set of | ||
| # supported CodeQL languages. | ||
| # | ||
| name: "CodeQL" |
There was a problem hiding this comment.
do we really need this for this tiny tiny action?
There was a problem hiding this comment.
Maybe not. I copied this from https://github.com/scientific-python/action-check-changelogfile/tree/main/.github/workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11
Unresolved: How do we do meaningful testing here without overcomplicating the existing script? Is there a better way?
cc @bsipocz @larsoner