Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent result in unit test for "aps_randomized_cv_crossval" in classification #377

Closed
thibaultcordier opened this issue Nov 14, 2023 · 3 comments
Labels
Bug Type: bug Good first issue Easy issue to start to contribute to MAPIE Source: developers Proposed by developers.

Comments

@thibaultcordier
Copy link
Collaborator

Describe the bug
When the unit tests are run, one test gives inconsistent results (for the "aps_randomized_cv_crossval" method in the classification).

To Reproduce
Steps to reproduce the behavior:

  1. Run the test_toy_dataset_predictions test several times in mapie/tests/test_classification.py.

Expected behavior
Consistent results when tests are run several times.

@thibaultcordier thibaultcordier added the Bug Type: bug label Nov 14, 2023
thibaultcordier added a commit that referenced this issue Nov 14, 2023
CI/CD: change version of numpy and python for CI/CD
TMP: relaxing certain constraints #377 #378
@LacombeLouis LacombeLouis added the Good first issue Easy issue to start to contribute to MAPIE label Nov 17, 2023
@thibaultcordier thibaultcordier added the Source: developers Proposed by developers. label Dec 11, 2023
@BaptisteCalot
Copy link
Collaborator

Hello everyone ! I tried to reproduce the bug without success. How am I supposed to get a bad result? We agree that the inconsistent result is supposed to make the test fail, right ? @thibaultcordier

@BenoitGaston
Copy link

Hello everyone,

@thibaultcordier I confirm the comment made by @BaptisteCalot above.

Running test_toy_dataset_predictions with strategy = "aps_randomized_cv_crossval" 10k times is not giving me any error.

See the test function I created for that here :https://github.com/Sialcant/MAPIE-issue-377/blob/c633e2b71acef5d9d0b1f77f085a19a5e8e32b6e/mapie/tests/test_classification.py#L1461

Should I do something differently?

Best,

@thibaultcordier
Copy link
Collaborator Author

Hello @BaptisteCalot @BenoitGaston

Your feedback seems to be good and experience shows that the problem has not reappeared.
I am closing the issue accordingly.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Type: bug Good first issue Easy issue to start to contribute to MAPIE Source: developers Proposed by developers.
Projects
None yet
Development

No branches or pull requests

4 participants