Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch does not batch #110

Open
KevinColemanInc opened this issue Aug 19, 2018 · 3 comments
Open

Batch does not batch #110

KevinColemanInc opened this issue Aug 19, 2018 · 3 comments

Comments

@KevinColemanInc
Copy link
Contributor

I noticed that calling batch does not actually batch the sql queries. for every #row call, there is a new sql execution call.

I was expecting the batch to execute 1 query with all of the upsert changes.

@pnomolos
Copy link
Collaborator

This is a known issue which we’re hoping to address in the next version :)

@KevinColemanInc
Copy link
Contributor Author

Is there a branch with this feature being added? Maybe I could look at trying to finish it?

@pnomolos
Copy link
Collaborator

Not yet, things have been extremely slow over the summer and not much work has been done as this is also fairly low priority for us. I need to follow up with @seamusabshere again so we can even nail down an interface we’d like for version 2. That being said, you’re welcome to start work on something and we can fold it in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants