From ba6f4426b51102b8e730789b36bc706464edd9db Mon Sep 17 00:00:00 2001 From: Mehmet Sezer Date: Fri, 2 Sep 2022 20:06:24 +0300 Subject: [PATCH] Update WriteErrors error message (#964) * Update WriteErrors error message * Update error.go * Handle error nil case * Update error message for write errors * preallocate the errors slice Co-authored-by: Achille --- error.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/error.go b/error.go index 7181fde7..4a7a8a27 100644 --- a/error.go +++ b/error.go @@ -684,7 +684,6 @@ func makeError(code int16, message string) error { // // handle other errors // ... // } -// type WriteErrors []error // Count counts the number of non-nil errors in err. @@ -701,5 +700,13 @@ func (err WriteErrors) Count() int { } func (err WriteErrors) Error() string { - return fmt.Sprintf("kafka write errors (%d/%d)", err.Count(), len(err)) + errCount := err.Count() + errors := make([]string, 0, errCount) + for _, writeError := range err { + if writeError == nil { + continue + } + errors = append(errors, writeError.Error()) + } + return fmt.Sprintf("Kafka write errors (%d/%d), errors: %v", errCount, len(err), errors) }