Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitbucket incorrectly reports repository name without owner name as slug #136

Open
ghengeveld opened this issue Jan 29, 2021 · 1 comment · May be fixed by #137
Open

Bitbucket incorrectly reports repository name without owner name as slug #136

ghengeveld opened this issue Jan 29, 2021 · 1 comment · May be fixed by #137

Comments

@ghengeveld
Copy link
Contributor

According to env-ci, a slug takes the form owner_name/repo_name of the repository currently being built. It's currently implemented using BITBUCKET_REPO_SLUG.

However, according to Bitbucket, BITBUCKET_REPO_SLUG is the URL-friendly version of a repository name. They provide foobar and foo-bar as examples. Clearly this is incompatible.

I think this should be changed to use BITBUCKET_REPO_FULL_NAME, which is described as The full name of the repository (everything that comes after http://bitbucket.org/). While that's poorly described, it appears to be exactly what we're after (owner_name/repo_name), as confirmed by some googling.
@ghengeveld ghengeveld linked a pull request Jan 29, 2021 that will close this issue
Open
@gr2m
Copy link
Member

gr2m commented Oct 18, 2021

please see my question at #137 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix slug to follow owner_name/repo_name format ghengeveld/env-ci
2 participants
@gr2m @ghengeveld