Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove euclid dependency #208

Open
kvark opened this issue Nov 3, 2020 · 7 comments
Open

Remove euclid dependency #208

kvark opened this issue Nov 3, 2020 · 7 comments

Comments

@kvark
Copy link
Member

kvark commented Nov 3, 2020

It's unclear what value euclud brings here. A cursory look reveals only Point2D and Size2D used, and surfman could just roll out its own structures for this.

@avr1
Copy link

avr1 commented Dec 23, 2020

@kvark I'd like to take a look at this, but I'm a little confused as to how to approach the problem. Should I make my own definitions of the Euclid structures, and if so, where in the codebase should I store them and refer all other calls to those structures to? Thanks!

@kvark
Copy link
Member Author

kvark commented Dec 23, 2020

@avr1 Sorry! I stopped using surfman in gfx-rs and opted into talking to EGL directly instead, so I can't help here.

@avr1
Copy link

avr1 commented Dec 23, 2020

Thanks anyway! @jdm, do you think I should make my own definitions of the Euclid structures used, and if so, where do you suggest I put them? If not, should we continue to use euclid?

@jdm
Copy link
Member

jdm commented Dec 23, 2020

Yeah, I would just put them in the root of surfman, or maybe make a geom module that's publicly visible.

@avr1
Copy link

avr1 commented Dec 23, 2020

@jdm Sorry to ask such a newb question, but where exactly is the root of surfman, and how would I access that in the subdirectories? I've been fighting a losing war with the module system.

@jdm
Copy link
Member

jdm commented Dec 24, 2020

@jdm
Copy link
Member

jdm commented Dec 24, 2020

From submodules you could refer to use crate::{Size2D, Point2D};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants