Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable StrictMode everywhere in spec/dummy #1465

Open
alexeyr-ci1 opened this issue Jun 27, 2022 · 4 comments
Open

Enable StrictMode everywhere in spec/dummy #1465

alexeyr-ci1 opened this issue Jun 27, 2022 · 4 comments
Labels
enhancement

Comments

@alexeyr-ci1
Copy link
Contributor

See https://reactjs.org/docs/strict-mode.html. This should help detect more bugs in RoR.
@alexeyr-ci1 alexeyr-ci1 changed the title Enable StrictMode for spec/dummy Enable StrictMode everywhere in spec/dummy Jun 27, 2022
@justin808
Copy link
Member

@alexeyr-ci1 SGTM

@alexeyr-ci1
Copy link
Contributor Author

alexeyr-ci1 commented Jul 6, 2022 •
edited
Loading

@justin808 After #1463 to avoid doing the work twice, StrictMode added some more restrictions in React 18.

@ahangarha
Copy link
Contributor

ahangarha commented Oct 27, 2022 •
edited
Loading

... StrictMode added some more restrictions in React 18.

In bad way? Anything particular apart from twice rendering which is deliberate?

May you please elaborate on this? @alexeyr-ci1

@alexeyr-ci1
Copy link
Contributor Author

In bad way? Anything particular apart from twice rendering which is deliberate?

No, in a good way which catches more errors, which is what we want StrictMode for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justin808 @ahangarha @alexeyr-ci1