From 73d634e6d6d06f0563b1f66a6d970379bc792880 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 3 Sep 2023 08:58:38 +1200 Subject: [PATCH 1/6] ci: update `actions/checkout` to v3 --- .github/workflows/lint-js-and-ruby.yml | 2 +- .github/workflows/main.yml | 4 ++-- .github/workflows/package-js-tests.yml | 2 +- .github/workflows/rspec-package-specs.yml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/lint-js-and-ruby.yml b/.github/workflows/lint-js-and-ruby.yml index 8e85f58a8..4d115385f 100644 --- a/.github/workflows/lint-js-and-ruby.yml +++ b/.github/workflows/lint-js-and-ruby.yml @@ -10,7 +10,7 @@ jobs: node: [18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup Ruby uses: ruby/setup-ruby@v1 with: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7eca1775f..d8e3534d4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -10,7 +10,7 @@ jobs: node: [16, 18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup Ruby uses: ruby/setup-ruby@v1 with: @@ -82,7 +82,7 @@ jobs: rake_task: ['run_rspec:all_but_examples', 'run_rspec:examples'] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup Ruby uses: ruby/setup-ruby@v1 with: diff --git a/.github/workflows/package-js-tests.yml b/.github/workflows/package-js-tests.yml index cbceb703c..1f6cf7ad4 100644 --- a/.github/workflows/package-js-tests.yml +++ b/.github/workflows/package-js-tests.yml @@ -9,7 +9,7 @@ jobs: node: [16, 18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup Node uses: actions/setup-node@v2-beta with: diff --git a/.github/workflows/rspec-package-specs.yml b/.github/workflows/rspec-package-specs.yml index 548509c62..51b6752dc 100644 --- a/.github/workflows/rspec-package-specs.yml +++ b/.github/workflows/rspec-package-specs.yml @@ -10,7 +10,7 @@ jobs: node: [16, 18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3 - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From a552322f965acfabf7d8bc40d98f4450bd2cda62 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 3 Sep 2023 09:00:22 +1200 Subject: [PATCH 2/6] ci: update `actions/setup-node` to v3 --- .github/workflows/lint-js-and-ruby.yml | 2 +- .github/workflows/main.yml | 4 ++-- .github/workflows/package-js-tests.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint-js-and-ruby.yml b/.github/workflows/lint-js-and-ruby.yml index 4d115385f..c4e61693f 100644 --- a/.github/workflows/lint-js-and-ruby.yml +++ b/.github/workflows/lint-js-and-ruby.yml @@ -17,7 +17,7 @@ jobs: ruby-version: ${{ matrix.ruby }} bundler: 2.4.17 - name: Setup Node - uses: actions/setup-node@v2-beta + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Print system information diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index d8e3534d4..f35de3fcd 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -21,7 +21,7 @@ jobs: - name: Fix dependency for libyaml-dev run: sudo apt install libyaml-dev - name: Setup Node - uses: actions/setup-node@v2-beta + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Print system information @@ -89,7 +89,7 @@ jobs: ruby-version: ${{ matrix.ruby }} bundler: 2.4.17 - name: Setup Node - uses: actions/setup-node@v2-beta + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Print system information diff --git a/.github/workflows/package-js-tests.yml b/.github/workflows/package-js-tests.yml index 1f6cf7ad4..07ef2edf6 100644 --- a/.github/workflows/package-js-tests.yml +++ b/.github/workflows/package-js-tests.yml @@ -11,7 +11,7 @@ jobs: steps: - uses: actions/checkout@v3 - name: Setup Node - uses: actions/setup-node@v2-beta + uses: actions/setup-node@v3 with: node-version: ${{ matrix.node }} - name: Print system information From aeaaf3fd1b7bf1f69ba192b5af3449c1466b742b Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 3 Sep 2023 09:01:00 +1200 Subject: [PATCH 3/6] ci: update `actions/cache` to v3 --- .github/workflows/lint-js-and-ruby.yml | 4 ++-- .github/workflows/package-js-tests.yml | 2 +- .github/workflows/rspec-package-specs.yml | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/lint-js-and-ruby.yml b/.github/workflows/lint-js-and-ruby.yml index c4e61693f..5542ffb2e 100644 --- a/.github/workflows/lint-js-and-ruby.yml +++ b/.github/workflows/lint-js-and-ruby.yml @@ -30,12 +30,12 @@ jobs: echo "Yarn version: "; yarn --version echo "Bundler version: "; bundle --version - name: Save root node_modules to cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: node_modules key: v5-package-node-modules-cache-${{ hashFiles('yarn.lock') }} - name: Save root ruby gems to cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: vendor/bundle key: v5-package-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }} diff --git a/.github/workflows/package-js-tests.yml b/.github/workflows/package-js-tests.yml index 07ef2edf6..3c91fbbc5 100644 --- a/.github/workflows/package-js-tests.yml +++ b/.github/workflows/package-js-tests.yml @@ -22,7 +22,7 @@ jobs: echo "Node version: "; node -v echo "Yarn version: "; yarn --version - name: Save root node_modules to cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: node_modules key: v5-package-node-modules-cache-${{ hashFiles('yarn.lock') }} diff --git a/.github/workflows/rspec-package-specs.yml b/.github/workflows/rspec-package-specs.yml index 51b6752dc..481b6bab5 100644 --- a/.github/workflows/rspec-package-specs.yml +++ b/.github/workflows/rspec-package-specs.yml @@ -26,7 +26,7 @@ jobs: echo "Yarn version: "; yarn --version echo "Bundler version: "; bundle --version - name: Save root ruby gems to cache - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: vendor/bundle key: v5-package-app-gem-cache-${{ hashFiles('react_on_rails.gemspec') }} From 6fbb0c67644e8c80ebe75e1431384ca8e13f49ce Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 3 Sep 2023 09:02:04 +1200 Subject: [PATCH 4/6] ci: update `actions/upload-artifact` to v3 --- .github/workflows/main.yml | 8 ++++---- .github/workflows/rspec-package-specs.yml | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index f35de3fcd..9ec8c1954 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -162,22 +162,22 @@ jobs: - name: Main CI run: bundle exec rake ${{ matrix.rake_task }} - name: Store test results - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: main-rspec path: ~/rspec - name: Store artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: dummy-app-capybara path: spec/dummy/tmp/capybara - name: Store artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: dummy-app-test-log path: spec/dummy/log/test.log - name: Store artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: dummy-app-yarn-log path: spec/dummy/yarn-error.log diff --git a/.github/workflows/rspec-package-specs.yml b/.github/workflows/rspec-package-specs.yml index 481b6bab5..020369585 100644 --- a/.github/workflows/rspec-package-specs.yml +++ b/.github/workflows/rspec-package-specs.yml @@ -35,12 +35,12 @@ jobs: - name: Run rspec tests run: bundle exec rspec spec/react_on_rails - name: Store test results - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: main-rspec path: ~/rspec - name: Store artifacts - uses: actions/upload-artifact@v2 + uses: actions/upload-artifact@v3 with: name: main-test-log path: log/test.log From a41b664ac31547a9f9709ef86d3172ff163a9df6 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sun, 3 Sep 2023 09:03:45 +1200 Subject: [PATCH 5/6] ci: disable persisted git credentials for improved security --- .github/workflows/lint-js-and-ruby.yml | 2 ++ .github/workflows/main.yml | 4 ++++ .github/workflows/package-js-tests.yml | 2 ++ .github/workflows/rspec-package-specs.yml | 2 ++ 4 files changed, 10 insertions(+) diff --git a/.github/workflows/lint-js-and-ruby.yml b/.github/workflows/lint-js-and-ruby.yml index 5542ffb2e..82ad128fe 100644 --- a/.github/workflows/lint-js-and-ruby.yml +++ b/.github/workflows/lint-js-and-ruby.yml @@ -11,6 +11,8 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + with: + persist-credentials: false - name: Setup Ruby uses: ruby/setup-ruby@v1 with: diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9ec8c1954..4ddebd0bb 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,6 +11,8 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + with: + persist-credentials: false - name: Setup Ruby uses: ruby/setup-ruby@v1 with: @@ -83,6 +85,8 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + with: + persist-credentials: false - name: Setup Ruby uses: ruby/setup-ruby@v1 with: diff --git a/.github/workflows/package-js-tests.yml b/.github/workflows/package-js-tests.yml index 3c91fbbc5..6b81424e5 100644 --- a/.github/workflows/package-js-tests.yml +++ b/.github/workflows/package-js-tests.yml @@ -10,6 +10,8 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + with: + persist-credentials: false - name: Setup Node uses: actions/setup-node@v3 with: diff --git a/.github/workflows/rspec-package-specs.yml b/.github/workflows/rspec-package-specs.yml index 020369585..9d641409e 100644 --- a/.github/workflows/rspec-package-specs.yml +++ b/.github/workflows/rspec-package-specs.yml @@ -11,6 +11,8 @@ jobs: runs-on: ubuntu-22.04 steps: - uses: actions/checkout@v3 + with: + persist-credentials: false - name: Setup Ruby uses: ruby/setup-ruby@v1 with: From 6016005ef95668504c20fe9adb2bcf875c7ac9b2 Mon Sep 17 00:00:00 2001 From: Gareth Jones Date: Sat, 9 Sep 2023 11:26:08 +1200 Subject: [PATCH 6/6] ci: update `actions/checkout` to v4 --- .github/workflows/lint-js-and-ruby.yml | 2 +- .github/workflows/main.yml | 4 ++-- .github/workflows/package-js-tests.yml | 2 +- .github/workflows/rspec-package-specs.yml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/lint-js-and-ruby.yml b/.github/workflows/lint-js-and-ruby.yml index 82ad128fe..d15a437ba 100644 --- a/.github/workflows/lint-js-and-ruby.yml +++ b/.github/workflows/lint-js-and-ruby.yml @@ -10,7 +10,7 @@ jobs: node: [18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Setup Ruby diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 4ddebd0bb..3a05710d1 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -10,7 +10,7 @@ jobs: node: [16, 18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Setup Ruby @@ -84,7 +84,7 @@ jobs: rake_task: ['run_rspec:all_but_examples', 'run_rspec:examples'] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Setup Ruby diff --git a/.github/workflows/package-js-tests.yml b/.github/workflows/package-js-tests.yml index 6b81424e5..3a588eaab 100644 --- a/.github/workflows/package-js-tests.yml +++ b/.github/workflows/package-js-tests.yml @@ -9,7 +9,7 @@ jobs: node: [16, 18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Setup Node diff --git a/.github/workflows/rspec-package-specs.yml b/.github/workflows/rspec-package-specs.yml index 9d641409e..a31a4ea42 100644 --- a/.github/workflows/rspec-package-specs.yml +++ b/.github/workflows/rspec-package-specs.yml @@ -10,7 +10,7 @@ jobs: node: [16, 18] runs-on: ubuntu-22.04 steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: persist-credentials: false - name: Setup Ruby