Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y keyboard navigation and screen reader improvements #3721

Open
10 tasks
wayne-shih opened this issue Nov 20, 2024 · 4 comments
Open
10 tasks

a11y keyboard navigation and screen reader improvements #3721

wayne-shih opened this issue Nov 20, 2024 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@wayne-shih
Copy link
Contributor

wayne-shih commented Nov 20, 2024 •
edited
Loading

Some accessibility fixes I'm planning on patching when I've got some time, jotting it down as a start...

  • Skip to content for keyboard navigation (something like GDS) WONT FIX : this is avaliable in v4
  • Missing aria-label
    • Search box input
    • Breadcrumb (follow NHS / APG) -- also change div to nav
  • SVGs add role="presentation" when pre-described by other content
    • Top nav grouped dropdown, chevron icon
    • Light/dark mode icon
    • Sidebar collapse icon (more investigation needed to see if this is actually required)
  • ARIA hidden element must not be focusable or contain focusable elements
    • "Scroll to top"
@wayne-shih wayne-shih added the enhancement New feature or request label Nov 20, 2024
@dimaMachina
Copy link
Collaborator

Happy to accept PR! Loved your previous contribution 😄

@dimaMachina dimaMachina added the help wanted Extra attention is needed label Nov 20, 2024
@dimaMachina
Copy link
Collaborator

Skip to content

skip to content was moved to nextra/components in v4 and is built in with nextra-theme-docs v4

nextra/packages/nextra-theme-docs/src/layout.tsx

Line 102 in c9db20f

<SkipNavLink />

@wayne-shih
Copy link
Contributor Author

Skip to content

skip to content was moved to nextra/components in v4 and is built in with nextra-theme-docs v4

nextra/packages/nextra-theme-docs/src/layout.tsx

Line 102 in c9db20f

<SkipNavLink />

Ah nice! good to know, I'll cross that off my list for v3 fixes then.

I haven't tried v4 yet -- will have a look at that too. Are you guys aiming towards a stable release data for v4?

@dimaMachina
Copy link
Collaborator

dimaMachina commented Nov 20, 2024 •
edited
Loading

I haven't tried v4 yet -- will have a look at that too. Are you guys aiming towards a stable release data for v4?

yes, first blog post with migration guide and v4.rc.0, and after couple of weeks stable release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimaMachina @wayne-shih