Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Repo is a Demonstration / Showcase, not a module. #19

Open
simeydotme opened this issue Nov 7, 2022 · 0 comments
Open

This Repo is a Demonstration / Showcase, not a module. #19

simeydotme opened this issue Nov 7, 2022 · 0 comments
Labels
📖 documentation Improvements or additions to documentation 🔥 read hot / important

Comments

@simeydotme
Copy link
Owner

simeydotme commented Nov 7, 2022

There's no scenario where this repo will be available on NPM as an installable module.

This is a demo of the unique and cool holographic effects of Pokemon Cards.
So by that measure the CSS, JS and Svelte files in this repo are subject to the following points;

  • They will not be available on NPM for you to use in your own projects
  • The CSS/JS are dependent for the effect to work, and thus are not separable
  • The Svelte files will not be converted to [insert your framework of choice, probably react]
  • There is no scenario where this code is useful for your application
  • You will need to do significant work to make this useful to your use-case

With that said, I would like at some point, to build a generator for the holographic effect, and an npm module for hoverable-cards Svelte Component (without all the extra demo-specific stuff). But that is subject to my time and energy. I already have a branch for it, so please don't offer to build it for me.

These Pokemon Holo effects are incredibly heavy and terrible for website performance.

Just because I've shown that you can do it in CSS, doesn't mean everyone should do it. They are better left as a demonstration and example and not put on your NFT website. These effects will not take your tokens to the 🌔 .

Do not come back here complaining that your phone exploded, or your website crashed. This is a real possibility.

Browser performance for 3d transforms and filters/blends is severely lacking. I've done the best I can do optimise this demo and not cook your phone, but if you apply them to your own application I cannot say how diligent you will be.

@simeydotme simeydotme added 📖 documentation Improvements or additions to documentation question Further information is requested labels Nov 7, 2022
@simeydotme simeydotme pinned this issue Nov 7, 2022
Repository owner locked as too heated and limited conversation to collaborators Nov 7, 2022
@simeydotme simeydotme added 🔥 read hot / important and removed question Further information is requested labels Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 documentation Improvements or additions to documentation 🔥 read hot / important
Projects
None yet
Development

No branches or pull requests

1 participant