Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add built-in types to RESERVED_NAMES #2313

Open
nissa-seru opened this issue Oct 22, 2024 · 1 comment
Open

[core] Add built-in types to RESERVED_NAMES #2313

nissa-seru opened this issue Oct 22, 2024 · 1 comment
Labels
Core Issues in jadx-core module enhancement rename
Milestone

Comments

@nissa-seru
Copy link

Issue details

I would recommend adding built-in types to the RESERVED_NAMES constant in NameMapper, such that jadx will rename identifiers comprised of these strings. They are not valid user-assigned identifiers (due to the name collision), and are attractive obfuscation remaps due to the issues that they can cause. Note that jadx-gui rename action in editor does not work for identifiers that collide with built-in type names (the right-click rename in folder view must be used.)

Sharing my recommended list in "Relevant log output or stacktrace field" of this form.

Relevant log output or stacktrace

"Object",
              "String",
              "Integer",
              "Long",
              "Double",
              "Float",
              "Boolean",
              "Character",
              "Byte",
              "Short",
              "Void",
              "Class",
              "Enum",
              "Throwable",
              "Exception",
              "Error",
              "Thread",
              "Runnable",
              "System",
              "Math",
              "StringBuilder",
              "StringBuffer",
              "Array",
              "List",
              "Map",
              "Set",
              "HashMap",
              "HashSet",
              "LinkedList",
              "Arrays",
              "Collections"

Provide sample and class/method full name

N/A

Jadx version

Clone of master

@nissa-seru nissa-seru added bug Core Issues in jadx-core module labels Oct 22, 2024
@nissa-seru
Copy link
Author

It looks like this has been mistagged as Bug (something like Enhancement would be more appropriate.) Apologies, I am having trouble fixing the tag when I try to edit the issue.

@skylot skylot added this to the TBD milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issues in jadx-core module enhancement rename
Projects
None yet
Development

No branches or pull requests

2 participants