Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use schema validation to validate user input #144

Open
wa0x6e opened this issue Aug 28, 2023 · 0 comments
Open

refactor: use schema validation to validate user input #144

wa0x6e opened this issue Aug 28, 2023 · 0 comments

Comments

@wa0x6e
Copy link
Contributor

wa0x6e commented Aug 28, 2023

The current user input validation is using different if/else to check for valid data

const msg = req.body.data?.message;
if (!msg) {
return res.status(400).json({
error: 'Invalid format request'
});
}
if (!req.body.data.types.Space && !msg.settings && !msg.space) {
return res.status(400).json({
error: 'Missing space'
});
}
let address;
try {
address = getAddress(req.body.address);
} catch (e: any) {
return res.status(400).json({
error: 'Invalid address'
});
}

We should move this to a cleaner implementation, using schema validation, like on sequencer (#140 (comment))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant