Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor windowed to use a backing array interface #44

Open
Raynos opened this issue Dec 17, 2019 · 3 comments
Open

Refactor windowed to use a backing array interface #44

Raynos opened this issue Dec 17, 2019 · 3 comments

Comments

@Raynos
Copy link
Contributor

Raynos commented Dec 17, 2019

Currently windowed reads & renders from this.rows which is an array.

By changing that to an interface it can be swapped to by anything that's a synchronous API like C++ or lmdb
@Raynos Raynos self-assigned this Dec 17, 2019
@heapwolf
Copy link
Member

heapwolf commented Apr 6, 2020

This is done.

@heapwolf heapwolf closed this as completed Apr 6, 2020
@Raynos Raynos reopened this Apr 6, 2020
@Raynos
Copy link
Contributor Author

Raynos commented Apr 6, 2020

This is not done yet, the rows field is still public instead of private which does not allow it to be swapped easily without a breaking change.

@heapwolf
Copy link
Member

heapwolf commented Apr 9, 2020

Oh haha sorry my bad :)

@Raynos Raynos removed their assignment Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heapwolf @Raynos