Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[admin] Consider committing the built tailwind css file into the admin repo #5655

Open
elia opened this issue Feb 8, 2024 · 1 comment
Open
Assignees

Comments

@elia
Copy link
Member

elia commented Feb 8, 2024

          What do you think about committing the built tailwind css file into the admin repo (and update it on PR merge)? That file won't change much (at least once the admin has been built out). And even until then it makes sense to have it updated regularly (not just on gem release).

People might use solidus_admin from git source like this

# Gemfile
gem "solidus_admin", github: "solidusio/solidus", branch: "v4.3"

(in order to get bug fixes early for stable versions that have not been released yet.)

We want to make sure they get the admin css file, right?

Originally posted by @tvdeyen in #5595 (comment)

@tvdeyen
Copy link
Member

tvdeyen commented Oct 18, 2024

With the recent issues on CircleCI regarding the tailwind rake task we install in all host apps (!!) I think we really should do that. We are doing this for a very long time in Alchemy and we have zero issues or complaints.

@tvdeyen tvdeyen self-assigned this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants