-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend: use of cdn causes remixicon.symbol.svg to not download due to its being an svg used with <use> tag #5657
Comments
Got the exact same issue today. I'll report back with what I end up doing to fix it. |
I found some good documentation regarding the issue, and tried preloading the file from the using the |
My guess is that this component is playing nice with the CDN setup:
|
We have the same issue in Alchemy and one proposed solution is to preload the asset with CORS enabled
|
Solidus Version:
Solidus 4.3
To Reproduce
Deploy app with
Rails.application.config.asset_host
set to a cdn.Current behavior
The "remixicon.symbol.svg" file used for admin menu icons fails to download.
Expected behavior
Should be able to download the svg file and show admin menu icons.
Additional context
It seems like use of svg files with
<use>
tag has issues when served from cdn.I could not make it work through cdn settings, etc, so I would like to raise this as an issue.
I think I was able to resolve this issue by overriding
asset_host
inSpree::Admin::BaseController
as follows, but I'm not sure if this is an optimal way to solve this:I hope a fix is provided or the documentation is updated to discuss this in detail.
Thank you🙏
Screenshots
The text was updated successfully, but these errors were encountered: